GH-49415: [C++] Don't change map type key/item/value field names#49416
GH-49415: [C++] Don't change map type key/item/value field names#49416kou merged 1 commit intoapache:mainfrom
Conversation
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
@wgtmac @lidavidm @wjones127 What do you think about this? This code was changed by #35298 and you worked on the PR. |
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
I wonder if any users may have inadvertently come to depend on this behavior. Should we highlight it as a potentially breaking change?
github-actions
bot
added
awaiting merge
|
I think I've recently encountered a similar issue where Parquet and Arrow uses different hardcoded field names for map type: #49218 (comment) |
OK. I've updated the PR description for it. FYI: @raulcd you may be a release manager for the next major release. We want to highlight this change in the release announce blog post. |
|
I'll merge this. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 0bddf5d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
Hmm. The Go implementation also ignores key/item/value field names...: https://github.com/apache/arrow-go/blob/2de8b123a24f0e687fbfc590a0019c803037a076/arrow/ipc/metadata.go#L846 |
4 participants
Rationale for this change
The current implementation forces using
key/value/entriesas key/item/value field names and ignores field names in FlatBuffers.What changes are included in this PR?
Use field names in FlatBuffers.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
This PR includes breaking changes to public APIs. If an application depends on
key/value/entriesas map type's field names, an application may not work when incoming Apache Arrow data doesn't usekey/value/entries` as map type's field names.